-
Couldn't load subscription status.
- Fork 5.2k
Add analyzers and code-fixes to help adoption of source-generated COM #87223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add analyzers and code-fixes to help adoption of source-generated COM #87223
Conversation
…nd add tests for the various other analyzers we are going to introduce.
…n share it with the ComInterfaceGenerator-family of fixers.
…PIs instead of dropping to C#-specific syntax APIs (improves consistency throughout our code fixes)
…tToSourceGeneratedInteropFixer base type.
… of delegates" model.
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsFixes #86343 Also refactors a base class for our code-fixes to use that handles providing fix-all support and "enable allow unsafe blocks" support. Interesting aspects here for the analyzer/fixer:
|
....Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/AddGeneratedComClassTests.cs
Show resolved
Hide resolved
....Runtime.InteropServices/tests/ComInterfaceGenerator.Unit.Tests/AddGeneratedComClassTests.cs
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/gen/Common/ConvertToSourceGeneratedInteropFixer.cs
Outdated
Show resolved
Hide resolved
...gen/ComInterfaceGenerator/Analyzers/ComHostingDoesNotSupportGeneratedComInterfaceAnalyzer.cs
Show resolved
Hide resolved
...Services/gen/ComInterfaceGenerator/Analyzers/ConvertComImportToGeneratedComInterfaceFixer.cs
Outdated
Show resolved
Hide resolved
...es/System.Runtime.InteropServices/gen/ComInterfaceGenerator/Analyzers/AnalyzerDiagnostics.cs
Show resolved
Hide resolved
…ext. Update diagnostics list md.
|
Test failures are all known. |
Fixes #86343
Also refactors a base class for our code-fixes to use that handles providing fix-all support and "enable allow unsafe blocks" support.
Interesting aspects here for the analyzer/fixer:
newkeyword. We can try to make this smarter (validate members against base class, etc).EnableComHostingproperty from MSBuild to Roslyn.