Use HashCode.Combine() in interop source generators and analyzers instead of custom GetHashCode implementations #87221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsUse the HashCode.Combine from shared Roslyn code rather than use the custom implementations that xor the values together. This PR fixes all overrides of GetHashCode in System.Runtime.InteropServices.
|
Tornhoof
reviewed
Jun 7, 2023
src/libraries/System.Runtime.InteropServices/gen/ComInterfaceGenerator/ComInterfaceInfo.cs
Show resolved
Hide resolved
jkoritzinsky
approved these changes
Jun 7, 2023
This was referenced Jun 7, 2023
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the HashCode.Combine from shared Roslyn code rather than use the custom implementations that xor the values together. This PR fixes all overrides of GetHashCode in System.Runtime.InteropServices.
fixes #86104