Skip to content

Conversation

@sbomer
Copy link
Member

@sbomer sbomer commented Jun 2, 2023

I encountered some errors trying to build runtime with a preview6 SDK due to win-arm RIDs in various projects. This scrubs most references to win-arm that I found, with a few exceptions.

I wasn't sure if it's safe to remove these. I think it should be ok, because we shouldn't need to fall back from win-arm assets if they are entirely unsupported, but I've left these references for now:

"win-arm": {
"#import": [
"win"
]
},

"win-arm": [
"win-arm",
"win",
"any",
"base"
],

I assume these should stay as-is since they are .net6/.net7 manifests:

"Microsoft.NETCore.App.Runtime.net7.win-arm" : {
"kind": "framework",
"version": "${PackageVersionNet7}",
"alias-to": {
"any": "Microsoft.NETCore.App.Runtime.win-arm"
}
},

"Microsoft.NETCore.App.Runtime.net6.win-arm" : {
"kind": "framework",
"version": "${PackageVersionNet6}",
"alias-to": {
"any": "Microsoft.NETCore.App.Runtime.win-arm"
}
},

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Jun 2, 2023
@ghost ghost assigned sbomer Jun 2, 2023
@teo-tsirpanis teo-tsirpanis added area-Infrastructure and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Jun 2, 2023
@ghost
Copy link

ghost commented Jun 2, 2023

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Issue Details

I encountered some errors trying to build runtime with a preview6 SDK due to win-arm RIDs in various projects. This scrubs most references to win-arm that I found, with a few exceptions.

I wasn't sure if it's safe to remove these. I think it should be ok, because we shouldn't need to fall back from win-arm assets if they are entirely unsupported, but I've left these references for now:

"win-arm": {
"#import": [
"win"
]
},

"win-arm": [
"win-arm",
"win",
"any",
"base"
],

I assume these should stay as-is since they are .net6/.net7 manifests:

"Microsoft.NETCore.App.Runtime.net7.win-arm" : {
"kind": "framework",
"version": "${PackageVersionNet7}",
"alias-to": {
"any": "Microsoft.NETCore.App.Runtime.win-arm"
}
},

"Microsoft.NETCore.App.Runtime.net6.win-arm" : {
"kind": "framework",
"version": "${PackageVersionNet6}",
"alias-to": {
"any": "Microsoft.NETCore.App.Runtime.win-arm"
}
},

Author: sbomer
Assignees: sbomer
Labels:

area-Infrastructure

Milestone: -

@sbomer
Copy link
Member Author

sbomer commented Jun 2, 2023

Failure is #82637

@sbomer sbomer merged commit fd4e092 into dotnet:main Jun 2, 2023
@ghost ghost locked as resolved and limited conversation to collaborators Jul 3, 2023
@sbomer sbomer deleted the removeWinArmRIDs branch November 3, 2023 18:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants