Skip to content

[wasi] Fix support for paths with spaces #85022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 27, 2023
Merged

[wasi] Fix support for paths with spaces #85022

merged 4 commits into from
Apr 27, 2023

Conversation

@radical
Copy link
Member

@radical radical commented Apr 19, 2023 •
edited
Loading

  • Fix running tests locally
  • TODO: Add spaces for the sdk installed directory name too

Fixes #84878

@radical radical added arch-wasm WebAssembly architecture test-enhancement Improvements of test source code os-wasi Related to WASI variant of arch-wasm labels Apr 19, 2023
@radical radical requested review from lewing and maraf April 19, 2023 00:17
@radical radical requested a review from marek-safar as a code owner April 19, 2023 00:17
@ghost ghost added the area-Build-mono label Apr 19, 2023
@ghost ghost assigned radical Apr 19, 2023
@ghost
Copy link

ghost commented Apr 19, 2023

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • Use a directory name containing spaces for WBT
  • Fix running tests locally
  • TODO: Add spaces for the sdk installed directory name too

Fixes #84878

Author: radical
Assignees: -
Labels:

arch-wasm, test-enhancement, os-wasi
Milestone: -

@radical
Copy link
Member Author

radical commented Apr 19, 2023

/azp run runtime

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@build-analysis build-analysis bot mentioned this pull request Apr 19, 2023
Closed
@radical radical marked this pull request as draft April 19, 2023 15:26
@radical radical marked this pull request as ready for review April 27, 2023 15:58
lewing
lewing reviewed Apr 27, 2023
View reviewed changes
@build-analysis build-analysis bot mentioned this pull request Apr 27, 2023
Closed
@radical
Copy link
Member Author

radical commented Apr 27, 2023

Failures are known, and unrelated.

@radical radical merged commit 0c612cf into dotnet:main Apr 27, 2023
@radical radical deleted the wasi-wbt-spaces branch April 27, 2023 20:07
@lewing
Copy link
Member

lewing commented May 9, 2023

/backport to release/8.0-preview4

@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2023

Started backporting to release/8.0-preview4: https://github.com/dotnet/runtime/actions/runs/4928677357

@github-actions github-actions bot mentioned this pull request May 9, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@lewing lewing lewing approved these changes

@maraf maraf Awaiting requested review from maraf maraf is a code owner

@marek-safar marek-safar Awaiting requested review from marek-safar

Assignees

@radical radical

Labels

arch-wasm WebAssembly architecture area-Build-mono os-wasi Related to WASI variant of arch-wasm test-enhancement Improvements of test source code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[wasi] Unescaped file paths when compiling with WasmSingleFileBundle

2 participants

@radical @lewing