Skip to content

Updating XML doc comments for hardware intrinsics to include VEX and EVEX forms #84892

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 19, 2023
Merged

Updating XML doc comments for hardware intrinsics to include VEX and EVEX forms #84892

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ee0b13b
Updating XML doc comments for hardware intrinsics to include VEX and …
tannergooding Apr 16, 2023
2a6e66c
Fixing a formatting issue
tannergooding Apr 16, 2023
cea0431
Ensure all changes are actually committed
tannergooding Apr 16, 2023
a733a0b
Apply suggestions from code review
tannergooding Apr 16, 2023
a33c17b
Merge remote-tracking branch 'dotnet/main' into avx512
tannergooding Apr 18, 2023
abeb117
Add back a using that got removed in the merge
tannergooding Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions ...ries/System.Private.CoreLib/src/System/Runtime/Intrinsics/X86/Aes.PlatformNotSupported.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,40 +27,44 @@ internal X64() { }

/// <summary>
/// __m128i _mm_aesdec_si128 (__m128i a, __m128i RoundKey)
/// AESDEC xmm, xmm/m128
/// AESDEC xmm1, xmm2/m128
/// VAESDEC xmm1, xmm2, xmm3/m128
/// </summary>
public static Vector128<byte> Decrypt(Vector128<byte> value, Vector128<byte> roundKey) { throw new PlatformNotSupportedException(); }

/// <summary>
/// __m128i _mm_aesdeclast_si128 (__m128i a, __m128i RoundKey)
/// AESDECLAST xmm, xmm/m128
/// AESDECLAST xmm1, xmm2/m128
/// VAESDECLAST xmm1, xmm2, xmm3/m128
/// </summary>
public static Vector128<byte> DecryptLast(Vector128<byte> value, Vector128<byte> roundKey) { throw new PlatformNotSupportedException(); }

/// <summary>
/// __m128i _mm_aesenc_si128 (__m128i a, __m128i RoundKey)
/// AESENC xmm, xmm/m128
/// AESENC xmm1, xmm2/m128
/// VAESENC xmm1, xmm2, xmm3/m128
/// </summary>
public static Vector128<byte> Encrypt(Vector128<byte> value, Vector128<byte> roundKey) { throw new PlatformNotSupportedException(); }

/// <summary>
/// __m128i _mm_aesenclast_si128 (__m128i a, __m128i RoundKey)
/// AESENCLAST xmm, xmm/m128
/// AESENCLAST xmm1, xmm2/m128
/// VAESENCLAST xmm1, xmm2, xmm3/m128
/// </summary>
public static Vector128<byte> EncryptLast(Vector128<byte> value, Vector128<byte> roundKey) { throw new PlatformNotSupportedException(); }

/// <summary>
/// __m128i _mm_aesimc_si128 (__m128i a)
/// AESIMC xmm, xmm/m128
/// AESIMC xmm1, xmm2/m128
/// VAESIMC xmm1, xmm2/m128
/// </summary>
public static Vector128<byte> InverseMixColumns(Vector128<byte> value) { throw new PlatformNotSupportedException(); }

/// <summary>
/// __m128i _mm_aeskeygenassist_si128 (__m128i a, const int imm8)
/// AESKEYGENASSIST xmm, xmm/m128, imm8
/// AESKEYGENASSIST xmm1, xmm2/m128, imm8
/// VAESKEYGENASSIST xmm1, xmm2/m128, imm8
/// </summary>
public static Vector128<byte> KeygenAssist(Vector128<byte> value, [ConstantExpected] byte control) { throw new PlatformNotSupportedException(); }

}

}
18 changes: 12 additions & 6 deletions src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/X86/Aes.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,37 +27,43 @@ internal X64() { }

/// <summary>
/// __m128i _mm_aesdec_si128 (__m128i a, __m128i RoundKey)
/// AESDEC xmm, xmm/m128
/// AESDEC xmm1, xmm2/m128
/// VAESDEC xmm1, xmm2, xmm3/m128
/// </summary>
public static Vector128<byte> Decrypt(Vector128<byte> value, Vector128<byte> roundKey) => Decrypt(value, roundKey);

/// <summary>
/// __m128i _mm_aesdeclast_si128 (__m128i a, __m128i RoundKey)
/// AESDECLAST xmm, xmm/m128
/// AESDECLAST xmm1, xmm2/m128
/// VAESDECLAST xmm1, xmm2, xmm3/m128
/// </summary>
public static Vector128<byte> DecryptLast(Vector128<byte> value, Vector128<byte> roundKey) => DecryptLast(value, roundKey);

/// <summary>
/// __m128i _mm_aesenc_si128 (__m128i a, __m128i RoundKey)
/// AESENC xmm, xmm/m128
/// AESENC xmm1, xmm2/m128
/// VAESENC xmm1, xmm2, xmm3/m128
/// </summary>
public static Vector128<byte> Encrypt(Vector128<byte> value, Vector128<byte> roundKey) => Encrypt(value, roundKey);

/// <summary>
/// __m128i _mm_aesenclast_si128 (__m128i a, __m128i RoundKey)
/// AESENCLAST xmm, xmm/m128
/// AESENCLAST xmm1, xmm2/m128
/// VAESENCLAST xmm1, xmm2, xmm3/m128
/// </summary>
public static Vector128<byte> EncryptLast(Vector128<byte> value, Vector128<byte> roundKey) => EncryptLast(value, roundKey);

/// <summary>
/// __m128i _mm_aesimc_si128 (__m128i a)
/// AESIMC xmm, xmm/m128
/// AESIMC xmm1, xmm2/m128
/// VAESIMC xmm1, xmm2/m128
/// </summary>
public static Vector128<byte> InverseMixColumns(Vector128<byte> value) => InverseMixColumns(value);

/// <summary>
/// __m128i _mm_aeskeygenassist_si128 (__m128i a, const int imm8)
/// AESKEYGENASSIST xmm, xmm/m128, imm8
/// AESKEYGENASSIST xmm1, xmm2/m128, imm8
/// VAESKEYGENASSIST xmm1, xmm2/m128, imm8
/// </summary>
public static Vector128<byte> KeygenAssist(Vector128<byte> value, [ConstantExpected] byte control) => KeygenAssist(value, control);
}
Expand Down
Loading