Skip to content

Conversation

@davidsh
Copy link
Contributor

@davidsh davidsh commented Dec 13, 2019

Revised script to build the libraries subset due to changes with CoreCLR and live-live build.

@davidsh davidsh added this to the 5.0 milestone Dec 13, 2019
@davidsh davidsh self-assigned this Dec 13, 2019
@davidsh davidsh force-pushed the fix_pipeline branch 5 times, most recently from 6ac121d to 8158111 Compare December 13, 2019 22:06
Revised script to build the libraries subset due to changes with CoreCLR and live-live build.
@davidsh davidsh requested review from a team, joperezr and safern December 13, 2019 22:33
@davidsh
Copy link
Contributor Author

davidsh commented Dec 13, 2019

I got the build working again after the live-live changes:
image

So, please approve PR so I can merge. Thanks.

Copy link
Member

@joperezr joperezr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with the scenario for this pipeline, but changes LGTM.

@davidsh
Copy link
Contributor Author

davidsh commented Dec 14, 2019

I'm not super familiar with the scenario for this pipeline, but changes LGTM.

Thanks. If you're curious, you can look at the first PR for the Enterprise Scenarios Testing system. It describes some of the background and points to the README.md files.

Copy link
Member

@wfurt wfurt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@davidsh davidsh merged commit 496c2a6 into dotnet:master Dec 14, 2019
@davidsh davidsh deleted the fix_pipeline branch December 14, 2019 02:14
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ghost ghost locked as resolved and limited conversation to collaborators Dec 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants