Skip to content

Address timeouts in merged test groups #84193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 1, 2023
Merged

Address timeouts in merged test groups #84193

merged 4 commits into from
Apr 1, 2023

Conversation

@markples
Copy link
Contributor

@markples markples commented Mar 31, 2023 •
edited
Loading

See #68529 for theories.

Should solve the first timeouts in #83961 (baseservices/threading), Directed_1, Regression_1, and Regression_2 by marking tests as RequiresProcessIsolation.
Adds striping to Regression_1, Regression_4, threading_group1.

@ghost ghost assigned markples Mar 31, 2023
@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 31, 2023
@markples markples added test-bug Problem in test source code (most likely) area-Infrastructure-coreclr and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Mar 31, 2023
@ghost
Copy link

ghost commented Mar 31, 2023

Tagging subscribers to this area: @hoyosjs
See info in area-owners.md if you want to be subscribed.

Issue Details

See #68529 for theories

Author: markples
Assignees: markples
Labels:

test-bug, area-Infrastructure-coreclr
Milestone: -

@markples
Copy link
Contributor Author

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot Mar 31, 2023
@markples markples changed the title Mark 30032.csproj with RequiresProcessIsolation to avoid timeouts Address timeouts in merged test groups Mar 31, 2023
@markples
Copy link
Contributor Author

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

This was referenced Mar 31, 2023
Merged
Closed
jkoritzinsky
jkoritzinsky approved these changes Apr 1, 2023
View reviewed changes
Copy link
Member

@jkoritzinsky jkoritzinsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the comments in each test for why it's process isolated!

@build-analysis build-analysis bot mentioned this pull request Apr 1, 2023
Closed
@markples
Copy link
Contributor Author

markples commented Apr 1, 2023

/azp run runtime-coreclr gcstress0x3-gcstress0xc

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@markples
Copy link
Contributor Author

markples commented Apr 1, 2023

CI and gcstress passed with the latest iteration other than tests failing elsewhere

@markples markples merged commit c6adf4c into dotnet:main Apr 1, 2023
@markples markples mentioned this pull request Apr 3, 2023
Closed
@ghost ghost locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees

@markples markples

Labels

area-Infrastructure-coreclr test-bug Problem in test source code (most likely)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@markples @jkoritzinsky