-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[browser] legacy JS interop optional via WasmEnableLegacyJsInterop - native #82834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[browser] legacy JS interop optional via WasmEnableLegacyJsInterop - native #82834
Conversation
|
Tagging subscribers to 'arch-wasm': @lewing Issue DetailsInitial work to make trim legacy interop from native code and JavaScript. Changes
Future work
|
688deac to
f25546a
Compare
|
Please ensure none of these funcs are used by the jiterpreter (CI ideally will catch it but isn't guaranteed) |
@kg The rest of here should be just moving them into conditional block. I will re-base this on the other PR later. |
f25546a to
4e5b832
Compare
# Conflicts: # src/mono/wasi/runtime/CMakeLists.txt
|
CI failure is #80619 |
Initial work to make trim legacy interop from native code and JavaScript.
Split off from #79622
Changes
WasmEnableLegacyJsInteropMSBuild feature.WasmEnableLegacyJsInterop==falsewill not make the JS smaller. That would be follow-up work.ENABLE_LEGACY_JS_INTEROPin native codedriver.cunder#ifdef ENABLE_LEGACY_JS_INTEROPmono_wasm_get_delegate_invoke_refandmono_wasm_box_primitive_reflower in the same file.mono_wasm_get_type_nameandmono_wasm_get_type_aqnhigher in the same file.mono_wasm_typed_array_new_reffromcorebindings.ctodriver.ccore_initialize_internalstobindings_initialize_internalsand unified it withmono_initialize_internalsCORE_BINDINGSdefinitionlegacy_c_functionscwraps.tsandcorebindings.canddotnet.es6.lib.jsare sorted in the same ordermono_method_resolvetoexport_internal_apidotnet.es6.lib.jsdriven my environment variables, so that it could be configured at dev machine build timeEmscriptenEnvVarsinWasmApp.Native.targetswasm.projloadedFilesfrom 'Module' toruntimeHelpersFuture work