Unify Array enumerators between CoreCLR and NativeAOT #82751
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @agocke, @MichalStrehovsky, @jkotas Issue DetailsContributes to #82732
|
jkotas
force-pushed
the
array-enumerators
branch
from
5928743 to
7e52cf4
Compare
jkotas
force-pushed
the
array-enumerators
branch
from
7e52cf4 to
186db65
Compare
stephentoub
reviewed
Mar 1, 2023
src/coreclr/tools/aot/ILCompiler.Compiler/Compiler/DependencyAnalysis/NodeFactory.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Mar 1, 2023
src/libraries/System.Private.CoreLib/src/System/Array.Enumerators.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Mar 1, 2023
…nalysis/NodeFactory.cs Co-authored-by: Stephen Toub <[email protected]>
This was referenced Mar 2, 2023
|
Known errors according to the build analysis |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #82732
Reduces BasicMinimalApi native AOT size on Windows x64 by 68kB