Skip to content

[release/7.0] Fix multiple dumps from being generated #80708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2023
Merged

[release/7.0] Fix multiple dumps from being generated #80708

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 0 additions & 16 deletions src/coreclr/pal/src/exception/signal.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,22 +294,6 @@ void SEHCleanupSignals()
}
}

/*++
Function :
SEHCleanupAbort()

Restore default SIGABORT signal handlers

(no parameters, no return value)
--*/
void SEHCleanupAbort()
{
if (g_registered_signal_handlers)
{
restore_signal(SIGABRT, &g_previous_sigabrt);
}
}

/* internal function definitions **********************************************/

/*++
Expand Down
10 changes: 0 additions & 10 deletions src/coreclr/pal/src/include/pal/signal.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,14 +117,4 @@ Function :
--*/
void SEHCleanupSignals();

/*++
Function :
SEHCleanupAbort()

Restore default SIGABORT signal handlers

(no parameters, no return value)
--*/
void SEHCleanupAbort();

#endif /* _PAL_SIGNAL_HPP_ */
5 changes: 3 additions & 2 deletions src/coreclr/pal/src/thread/process.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2677,8 +2677,9 @@ PROCAbort(int signal)

PROCCreateCrashDumpIfEnabled(signal);

// Restore the SIGABORT handler to prevent recursion
SEHCleanupAbort();
// Restore all signals; the SIGABORT handler to prevent recursion and
// the others to prevent multiple core dumps from being generated.
SEHCleanupSignals();

// Abort the process after waiting for the core dump to complete
abort();
Expand Down