- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.2k
 
[wasm] WBT: Update expected blazor tfm to net8.0 to match the latest sdk #80241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
              
                    vargaz
  
              
              approved these changes
              
                  
                    Jan 5, 2023 
                  
              
              
            
            
              
                    lambdageek
  
              
              approved these changes
              
                  
                    Jan 5, 2023 
                  
              
              
            
            
| 
           /azp run runtime  | 
    
| 
          
Azure Pipelines successfully started running 1 pipeline(s). | 
    
| 
           This is a WBT only change, and WBT passed.  | 
    
              
                    maraf
  
              
              reviewed
              
                  
                    Jan 6, 2023 
                  
              
              
            
            
      Comment on lines
    
      31
     to 
      +32
    
  
  | public const string DefaultTargetFramework = "net8.0"; | ||
| public const string DefaultTargetFrameworkForBlazor = "net7.0"; | ||
| public const string DefaultTargetFrameworkForBlazor = "net8.0"; | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are leaving these two as separate for net9.0 cycle, right?
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Also, fixes #79514
-O1for some blazor tests when building forDebugconfig.Fixes Tests failed: Wasm.Build.Tests.BlazorWasmBuildPublishTests due to SIGKILL #70985 .