[wasm] Improve terser setup #79466
Merged
[wasm] Improve terser setup #79466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix ProducVersion - dotn't generate dummy linker functions
pavelsavara
added
arch-wasm
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
Member
Author
|
/azp run runtime-wasm |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kg
approved these changes
Dec 9, 2022
ghost
locked as resolved and limited conversation to collaborators
pavelsavara
commented
Jan 27, 2023
| for (let linked_function of linked_functions) { | ||
| const fn_template = `return __dotnet_runtime.__linker_exports.${linked_function}.apply(__dotnet_runtime, arguments)`; | ||
| DotnetSupportLib[linked_function] = new Function(fn_template); | ||
| DotnetSupportLib[linked_function] = new Function(""); |
Member
Author
There was a problem hiding this comment.
This change breaks calling into mono C functions on threads because replace_linker_placeholders is not installed there.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
dotnet.jsRelease uncompressed 342 162 bytes, 11 461 bytes smaller.