Skip to content

[release/7.0] Fix WebSockets.Client.ConnectTest crash for apple mobile platforms #75423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2022
Merged

[release/7.0] Fix WebSockets.Client.ConnectTest crash for apple mobile platforms #75423

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/libraries/System.Net.WebSockets.Client/tests/ConnectTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,14 @@ public static IEnumerable<object[]> ConnectAsync_CustomInvokerWithIncompatibleWe
yield return NoThrow(options => options.UseDefaultCredentials = false);
yield return Throw(options => options.Credentials = new NetworkCredential());
yield return Throw(options => options.Proxy = new WebProxy());
yield return Throw(options => options.ClientCertificates.Add(Test.Common.Configuration.Certificates.GetClientCertificate()));

// Will result in an exception on apple mobile platforms
// and crash the test.
if (PlatformDetection.IsNotAppleMobile)
{
yield return Throw(options => options.ClientCertificates.Add(Test.Common.Configuration.Certificates.GetClientCertificate()));
}

yield return NoThrow(options => options.ClientCertificates = new X509CertificateCollection());
yield return Throw(options => options.RemoteCertificateValidationCallback = delegate { return true; });
yield return Throw(options => options.Cookies = new CookieContainer());
Expand Down