Skip to content

[release/7.0] Fix Exp10M1(TSelf) and Round(TSelf, MidpointRounding) #75284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Sep 9, 2022
Merged

[release/7.0] Fix Exp10M1(TSelf) and Round(TSelf, MidpointRounding) #75284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4aff8c8
Don't ignore mode in IFloatingPoint.Round(TSelf, MipointRounding) DIM
blokyk Sep 3, 2022
06fe927
Fix recursion in IExponentialFunctions.Exp10M1's DIM
blokyk Sep 3, 2022
aa475f5
Add tests for IExponentialFunctions.Exp10M1's DIM
blokyk Sep 4, 2022
38b2d2e
Add tests for IFloatingPoint.Round's DIM
blokyk Sep 4, 2022
764dd65
fix nits from tannergooding
blokyk Sep 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/Numerics/IExponentialFunctions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,6 @@ public interface IExponentialFunctions<TSelf>
/// <summary>Computes <c>10</c> raised to a given power and subtracts one.</summary>
/// <param name="x">The power to which <c>10</c> is raised.</param>
/// <returns><c>10<sup><paramref name="x" /></sup> - 1</c></returns>
static virtual TSelf Exp10M1(TSelf x) => TSelf.Exp10M1(x) - TSelf.One;
static virtual TSelf Exp10M1(TSelf x) => TSelf.Exp10(x) - TSelf.One;
}
}
2 changes: 1 addition & 1 deletion src/libraries/System.Private.CoreLib/src/System/Numerics/IFloatingPoint.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ public interface IFloatingPoint<TSelf>
/// <param name="x">The value to round.</param>
/// <param name="mode">The mode under which <paramref name="x" /> should be rounded.</param>
/// <returns>The result of rounding <paramref name="x" /> to the nearest integer using <paramref name="mode" />.</returns>
static virtual TSelf Round(TSelf x, MidpointRounding mode) => TSelf.Round(x, digits: 0, MidpointRounding.ToEven);
static virtual TSelf Round(TSelf x, MidpointRounding mode) => TSelf.Round(x, digits: 0, mode);

/// <summary>Rounds a value to a specified number of fractional-digits using the default rounding mode (<see cref="MidpointRounding.ToEven" />).</summary>
/// <param name="x">The value to round.</param>
Expand Down
2 changes: 2 additions & 0 deletions src/libraries/System.Runtime/tests/System.Runtime.Tests.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,8 @@
<Compile Include="System\NullableMetadataTests.cs" />
<Compile Include="System\NullableTests.cs" />
<Compile Include="System\NullReferenceExceptionTests.cs" />
<Compile Include="System\Numerics\IExponentialFunctionsTests.cs" />
<Compile Include="System\Numerics\IFloatingPointTests.cs" />
<Compile Include="System\ObjectTests.cs" />
<Compile Include="System\ObjectDisposedExceptionTests.cs" />
<Compile Include="System\ObsoleteAttributeTests.cs" />
Expand Down
Loading