[release/7.0][wasm] Use the correct runtime pack version when the workload is not installed #75028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
.. if no workload is installed. This ensures that the correct runtime pack version (intended by the installed manifest) is used even if the workload is not installed.
.. runtime pack version is being used. To use the locally built runtime pack without the workload, we need the nuget, so we use that from the artifacts.
radical
force-pushed
the
fix-rpack-ver
branch
from
4b6cd91 to
2d26951
Compare
|
/azp run runtime-wasm-perf |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lewing
approved these changes
Sep 3, 2022
steveisok
approved these changes
Sep 3, 2022
radical
changed the title
|
Ping @marek-safar we need an approval, please. |
marek-safar
approved these changes
Sep 6, 2022
|
CI is green, approved and signed off. Ready to merge. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WorkloadManifest.targetshad the runtime pack version update conditioned on the workload being installed, which meant that the original version from the sdk was used if no workload was installed, ignoring the version from the manifest.