-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[release/6.0] Fix VS component versions #74324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue Details
|
|
We don't need this until the next servicing release as we can fix this up manually when we publish to VS. |
|
@carlossanlop Let's hold this one for 6.0.10 |
|
Tagging subscribers to this area: @directhex Issue Details
|
|
Is there any reason not to do the 7.0 version of this now? |
None that I can think of |
|
I'm going to continue pushing more of the 6.0 changes here so we can get everything ready in one go |
Hope you don't mind if I convert it to draft. |
|
This PR is blocked on dotnet/arcade#10582 We likely need to update it to include the Arcade changes once we have a validation build. Below is an example of what the new archives will look like |
|
@hoyosjs can you take another look at the PR. The |
|
The changes LGTM. |
|
ci is blocked on #75294 |
|
And it broke :( This will likely need #68847 |
|
tell mode packaging fix |

This update contains multiple fixes for issues that were identified during the last servicing release.
ItemDefinitionGroupis evaluated globally while theFileVersionproperty is only set after theGetAssemblyVersiontarget runs. This causes the VS components to assume the default workload version, which doesn't play well with upgrades in VS. The assembly file version value is preferred because it can change between builds, allow consecutive insertions into VS that can be upgraded.