Skip to content

Downgrade System.Reflection.Metadata in HostModel #74231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2022
Merged

Downgrade System.Reflection.Metadata in HostModel #74231

merged 1 commit into from
Aug 19, 2022

Conversation

@am11
Copy link
Member

@am11 am11 commented Aug 19, 2022 •
edited
Loading

In HostModel, we need to keep the version of System.Reflection.Metadata in sync with dotnet/msbuild and dotnet/sdk.

Downgrades 6.0.1 -> 6.0.0

@ghost ghost added area-HostModel Microsoft.NET.HostModel issues community-contribution Indicates that the PR has been added by a community member labels Aug 19, 2022
@ghost
Copy link

ghost commented Aug 19, 2022

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

Issue Details

In HostModel, we need to keep the version of System.Reflection.Metadata in sync with dotnet/msbuild and dotnet/sdk.

Author: am11
Assignees: -
Labels:

area-HostModel, community-contribution
Milestone: -

@am11 am11 mentioned this pull request Aug 19, 2022
Merged
@jkoritzinsky jkoritzinsky merged commit 06350b7 into dotnet:main Aug 19, 2022
@am11 am11 deleted the feature/hostmodel/update-dependencies branch August 19, 2022 14:56
@ViktorHofer
Copy link
Member

Did you consider upgrading the package versions in sdk and msbuild instead? Staying on the latest patch version does make sense IMO.

@jkoritzinsky
Copy link
Member

I think we should update the SDK and MSBuild, but I want to unblock the consumption of dotnet/runtime into the SDK and updating MSBuild involves coordinating with Roslyn and everything else that gets loaded into VS IIRC.

@am11
Copy link
Member Author

am11 commented Aug 19, 2022

Probably all these need to be in sync https://grep.app/search?q=%3CSystemReflectionMetadataVersion%3E%5B1-6%5D&regexp=true (aspnetcore is 7 rc1)

@ViktorHofer
Copy link
Member

@jkoritzinsky or @am11 can you please open an issue to discuss that? We should also think about how making this easier going forward.

@am11 am11 mentioned this pull request Aug 19, 2022
Closed
@ghost ghost locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

@MichalStrehovsky MichalStrehovsky Awaiting requested review from MichalStrehovsky

Assignees

No one assigned

Labels

area-HostModel Microsoft.NET.HostModel issues community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@am11 @ViktorHofer @jkoritzinsky