Skip to content

Conversation

@am11
Copy link
Member

@am11 am11 commented Jul 31, 2022

No description provided.

@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-Meta labels Jul 31, 2022
@ghost
Copy link

ghost commented Jul 31, 2022

Tagging subscribers to this area: @dotnet/area-meta
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: am11
Assignees: -
Labels:

area-Meta, community-contribution

Milestone: -

@am11 am11 requested a review from jkotas July 31, 2022 17:41
@danmoseley
Copy link
Member

Just curious did you use tooling for this? As it would have to understand how to split identifier names.

@am11
Copy link
Member Author

am11 commented Jul 31, 2022

I am repeating this method: #72314 (comment). In the current .typos.toml file, I have captured most of the false-positives (like Tigger) or ignorable words (like parm).

The capturing part is done by the typos utility. However, the fixing of typos is done manually as the tool quite frequently make mistakes with auto-correction and we may allow some words in certain contexts (like XML/Regex tests are using literature from books verbatim), but the same word can be fixed in other places. Then there are some paths which I revert before pushing the change to GitHub (eng/common, *.xlf, src/native/external etc.). I have pushed libunwind fixes upstream libunwind/libunwind#397, which we will pick up with next version upgrade (without needing to modify src/native/external/libunwind proactively).

@radical
Copy link
Member

radical commented Jul 31, 2022

Please make sure to run runtime-wasm, and runtime-extra-platforms .

@radical
Copy link
Member

radical commented Jul 31, 2022

/azp run runtime-wasm, runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@am11
Copy link
Member Author

am11 commented Aug 1, 2022

These failures seem unrelated to PR change. Example of a flaky test #67138 (comment) which failed here. Other legs timed out running tests.

Copy link
Member

@jkotas jkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jkotas jkotas merged commit 2201016 into dotnet:main Aug 1, 2022
@am11 am11 deleted the fix/typos branch August 2, 2022 18:01
@ghost ghost locked as resolved and limited conversation to collaborators Sep 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-Meta community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants