Skip to content

Switch extra platform coverage from windowsservercore-2004 to windowsservercore-ltsc2019 #69480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2022
Merged

Switch extra platform coverage from windowsservercore-2004 to windowsservercore-ltsc2019 #69480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7930d34
Switch extra coverage in outerloop from windowsservercore-2004 to win…
jakobbotsch May 18, 2022
9382700
Disable SerialPort tests on Windows Server Core
jakobbotsch May 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions eng/pipelines/libraries/helix-queues-setup.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,13 +129,13 @@ jobs:
- ${{ if or(eq(parameters.jobParameters.isExtraPlatforms, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}:
- Windows.Amd64.Server2022.Open
- ${{ if ne(parameters.jobParameters.testScope, 'outerloop') }}:
- (Windows.Server.Core.2004.Amd64.Open)windows.10.amd64.server20h2[email protected]/dotnet-buildtools/prereqs:windowsservercore-2004-helix-amd64-20200904200251-272704c
- (Windows.10.Amd64.ServerRS5.Open)windows.10.amd64.serverrs5[email protected]/dotnet-buildtools/prereqs:windowsservercore-ltsc2019-helix-amd64-20220502135740-56c6673
- ${{ if or(ne(parameters.jobParameters.isExtraPlatforms, true), eq(parameters.jobParameters.includeAllPlatforms, true)) }}:
- Windows.81.Amd64.Open
- Windows.10.Amd64.Server2022.ES.Open
- Windows.11.Amd64.ClientPre.Open
- ${{ if eq(parameters.jobParameters.testScope, 'outerloop') }}:
- (Windows.Server.Core.2004.Amd64.Open)windows.10.amd64.server20h2[email protected]/dotnet-buildtools/prereqs:windowsservercore-2004-helix-amd64-20200904200251-272704c
- (Windows.10.Amd64.ServerRS5.Open)windows.10.amd64.serverrs5[email protected]/dotnet-buildtools/prereqs:windowsservercore-ltsc2019-helix-amd64-20220502135740-56c6673
- ${{ if ne(parameters.jobParameters.runtimeFlavor, 'mono') }}:
- (Windows.Nano.1809.Amd64.Open)[email protected]/dotnet-buildtools/prereqs:nanoserver-1809-helix-amd64-08e8e40-20200107182504

Expand Down
6 changes: 3 additions & 3 deletions src/libraries/System.IO.Ports/tests/SerialPort/GetPortNames.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ public class GetPortNames : PortsTest
/// <summary>
/// Check that all ports either open correctly or fail with UnauthorizedAccessException (which implies they're already open)
/// </summary>
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoNorServerCore))]
[ActiveIssue("https://github.com/dotnet/runtime/issues/34490", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]
Copy link
Member

@jozkee jozkee May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This issue is closed.

Suggested change
[ActiveIssue("https://github.com/dotnet/runtime/issues/34490", TestPlatforms.Windows, TargetFrameworkMonikers.Netcoreapp, TestRuntimes.Mono)]

Copy link
Member Author

@jakobbotsch jakobbotsch May 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should submit a separate PR to see if this can be reenabled on Mono. This PR is not about System.IO.Ports so I would rather not change this and end up with two more rounds of CI in case this is still blocked on something.

@jakobbotsch was the failure consistent? it may be flakyness in the Ports test, did you hit retry? in any case, the best is to file an issue to address the error.

I did not retry. I doubt this is just flakyness given the two separate failing tests and their log output (File.Open failed for COM1 and PortHelper.GetPorts seems to correctly report the available ports, while SerialPort.PortNames does not).

public void OpenEveryPortName()
{
Expand All @@ -40,7 +40,7 @@ public void OpenEveryPortName()
/// Test that SerialPort.GetPortNames finds every port that the test helpers have found.
/// (On Windows, the latter uses a different technique to SerialPort to find ports).
/// </summary>
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoNorServerCore))]
public void AllHelperPortsAreInGetPortNames()
{
if (PlatformDetection.IsWindows && PlatformDetection.IsArmOrArm64Process)
Expand All @@ -62,7 +62,7 @@ public void AllHelperPortsAreInGetPortNames()
/// This catches regressions in the test helpers,
/// eg https://github.com/dotnet/corefx/pull/18928 / https://github.com/dotnet/corefx/pull/20668
/// </summary>
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoServer))]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotWindowsNanoNorServerCore))]
public void AllGetPortNamesAreInHelperPorts()
{
string[] helperPortNames = PortHelper.GetPorts();
Expand Down