-
Couldn't load subscription status.
- Fork 5.2k
[wasm] missing lint fixes #59969
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] missing lint fixes #59969
Conversation
pavelsavara
commented
Oct 4, 2021
- fixed all the issues
- updated readme
- enabled lint validation in CI
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
Tagging subscribers to 'arch-wasm': @lewing Issue Details
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some misc notes from looking at this:
x.apply(thisRef, args) and x(...args) are not necessarily equivalent in performance, so it's not always safe to make that change even if eslint is telling you to do it. I haven't seen us make this change in any performance sensitive spots, but please be aware of it.
The changes also brought to my attention that we are doing lazy initialization for cswraps members one at a time. I'm pretty sure this will have produced a performance regression, but we can address that later - just keep that in mind also if making changes like that in the future.
| } | ||
| } | ||
|
|
||
| type ListenerEstension = Function & { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extension
|
Unrelated failure |