Skip to content

Conversation

@pavelsavara
Copy link
Member

  • fixed all the issues
  • updated readme
  • enabled lint validation in CI

@pavelsavara pavelsavara added the arch-wasm WebAssembly architecture label Oct 4, 2021
@pavelsavara pavelsavara added this to the 7.0.0 milestone Oct 4, 2021
@pavelsavara pavelsavara requested review from kg and lewing October 4, 2021 21:05
@ghost
Copy link

ghost commented Oct 4, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Oct 4, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
  • fixed all the issues
  • updated readme
  • enabled lint validation in CI
Author: pavelsavara
Assignees: -
Labels:

arch-wasm

Milestone: 7.0.0

Copy link
Member

@kg kg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some misc notes from looking at this:

x.apply(thisRef, args) and x(...args) are not necessarily equivalent in performance, so it's not always safe to make that change even if eslint is telling you to do it. I haven't seen us make this change in any performance sensitive spots, but please be aware of it.

The changes also brought to my attention that we are doing lazy initialization for cswraps members one at a time. I'm pretty sure this will have produced a performance regression, but we can address that later - just keep that in mind also if making changes like that in the future.

}
}

type ListenerEstension = Function & {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extension

@pavelsavara
Copy link
Member Author

Unrelated failure

System.TypeLoadException: Method 'CompareSourceLocations' in type 'Microsoft.CodeAnalysis.CSharp.CSharpCompilation' from assembly 'Microsoft.CodeAnalysis.CSharp, Version=4.0.0.0, Culture=neutral, PublicKeyToken=31bf3856ad364e35' does not have an implementation.
   at Microsoft.DotNet.ApiCompatibility.AssemblySymbolLoader..ctor(Boolean resolveAssemblyReferences)
   at Microsoft.DotNet.PackageValidation.ApiCompatRunner.GetAssemblySymbolFromStream(Stream assemblyStream, MetadataInformation assemblyInformation, Boolean& resolvedReferences) in /_/src/Compatibility/Microsoft.DotNet.PackageValidation/ApiCompatRunner.cs:line 111
   at Microsoft.DotNet.PackageValidation.ApiCompatRunner.RunApiCompat() in /_/src/Compatibility/Microsoft.DotNet.PackageValidation/ApiCompatRunner.cs:line 49
   at Microsoft.DotNet.PackageValidation.CompatibleFrameworkInPackageValidator.Validate(Package package) in /_/src/Compatibility/Microsoft.DotNet.PackageValidation/CompatibleFrameworkInPackageValidator.cs:line 62
   at Microsoft.DotNet.Compatibility.ValidatePackage.ExecuteCore() in /_/src/Compatibility/Microsoft.DotNet.Compatibility/ValidatePackage.cs:line 92
   at Microsoft.NET.Build.Tasks.TaskBase.Execute() in /_/src/Tasks/Common/TaskBase.cs:line 38
   at Microsoft.DotNet.Compatibility.ValidatePackage.Execute() in /_/src/Compatibility/Microsoft.DotNet.Compatibility/ValidatePackage.cs:line 49
   at Microsoft.Build.BackEnd.TaskExecutionHost.Microsoft.Build.BackEnd.ITaskExecutionHost.Execute()
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(ITaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask)

@pavelsavara pavelsavara merged commit 68c0055 into dotnet:main Oct 5, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 4, 2021
@pavelsavara pavelsavara deleted the wasm_lint2 branch January 4, 2022 13:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants