Clean-up crossgen's NuGet dependencies et. al. #59914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
community-contribution
|
Hi @teo-tsirpanis, Thanks for submitting this PR. The change looks to be good, Could you please rebase to latest main, and rerun the tests. Once that is green we can merge. Thx. |
They were dragging along lots of packages, cluttering the dependency graph.
teo-tsirpanis
force-pushed
the
crossgen-package-cleanup
branch
from
a4cb50a to
bc8a33c
Compare
|
Hello @mangod9, I rebased, waiting for CI to complete. |
And expedite a condition check that does not involve BinaryReader.
davidwrighton
approved these changes
Oct 27, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes two unnecessary NuGet packages from crossgen-related projects and updates another one to its latest stable version, helping uncluttering the projects' dependency tree. Furthermore, it optimizes a function in crossgen's entry point to use spans, eliminating allocations.