Revert bind single elements to array in configuration binder #59716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e4a455f.
ghost
added
the
|
Tagging subscribers to this area: @maryamariyan, @safern Issue DetailsThe change we introduced in: #57204 and #57872 have raised two breaks in RC1, I think we are very late in the cycle to introduce more risk and try to fix those issues. We should revert this change and then try to do it again on 7.0.0 considering both issues that have been raised. We should port this to 6.0 branch as well. cc: @ericstj @danmoseley @vidommet
|
maryamariyan
approved these changes
Sep 28, 2021
Member
|
I'm supportive of a revert here. |
ericstj
approved these changes
Sep 28, 2021
eerhardt
approved these changes
Sep 28, 2021
Member
Author
|
/backport to release/6.0 |
Contributor
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1284748506 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change we introduced in: #57204 and #57872 have raised two breaks in RC1, I think we are very late in the cycle to introduce more risk and try to fix those issues.
#58852
#58330
We should revert this change and then try to do it again on 7.0.0 considering both issues that have been raised.
We should port this to 6.0 branch as well.
cc: @ericstj @danmoseley @vidommet