Remove validation to stat call for symlinks since is a breaking change #57551
Conversation
…e, subsequently remove the symlink cache logic as is no longer needed
|
Tagging subscribers to this area: @dotnet/area-system-io Issue DetailsSubsequently, remove the symlink cache logic as is no longer needed. cc @danmoseley
|
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
LGTM. Thanks for investigating this.
| } | ||
| } | ||
|
|
||
| [Theory] |
There was a problem hiding this comment.
These tests were validating that we throw when a self-referencing symlink is found in the recursion, while that is true for windows, that wasn't the case for Unix in 5.0, and it was going to be a breaking change caused by the same validation that I'm removing, so I updated the tests to ensure what is expected matches with 5.0
carlossanlop
left a comment
carlossanlop
left a comment
There was a problem hiding this comment.
LGTM with the latest test updates.
|
CI issues are nuget erros and test failure is #57452. |
ghost
locked as resolved and limited conversation to collaborators
2 participants
Subsequently, remove the symlink cache logic as is no longer needed.
Fixes #57221
cc @danmoseley