Implement DefType.IsUnsafeValueType #56790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MichalStrehovsky
approved these changes
Aug 3, 2021
Member
MichalStrehovsky
left a comment
MichalStrehovsky
left a comment
There was a problem hiding this comment.
I wish we could introduce the new property on MetadataType instead of DefType, but we don't have a place to cache things on MetadataType. Thanks!
src/coreclr/tools/Common/TypeSystem/Common/MetadataFieldLayoutAlgorithm.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/TypeSystem/Common/MetadataFieldLayoutAlgorithm.cs
Outdated
Show resolved
Hide resolved
src/coreclr/tools/Common/TypeSystem/Common/MetadataFieldLayoutAlgorithm.cs
Outdated
Show resolved
Hide resolved
davidwrighton
approved these changes
Aug 4, 2021
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: Michal Strehovský <[email protected]>
jakobbotsch
force-pushed
the
cg2-unsafe-valuetypes
branch
from
f8e385f to
2c2d996
Compare
Member
Author
|
I rebased to make sure I picked up #56889. /azp run runtime-coreclr outerloop |
Member
Author
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
The failures look to be preexisting. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into a test failure while working on #56669 because we did an unexpected tailcall. In the test (TailcallVerifyWithPrefix
TailcallVerify.Condition17.Test1) we expect not to do a fast tailcall because there is an unsafe value type and we expect to do a GS cookie check before exit, but because of this TODO we didn't.cc @dotnet/crossgen-contrib