Skip to content

[mono] Generate valid LLVM IR for vectors with unsupported element types #53132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
+26 −11
Closed

[mono] Generate valid LLVM IR for vectors with unsupported element types #53132

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
97599de
Synthesize undef values for SIMD types with invalid (non-primitive) e…
imhameed May 27, 2021
0d665d8
Extend support for the "simd-but-not-exactly-simd" hack to OP_LDADDR
imhameed May 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 26 additions & 11 deletions src/mono/mono/mini/mini-llvm.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -584,12 +584,9 @@ simd_class_to_llvm_type (EmitContext *ctx, MonoClass *klass)
case MONO_TYPE_R8:
return LLVMVectorType (LLVMDoubleType (), size / 8);
default:
g_assert_not_reached ();
return NULL;
return LLVMVectorType (LLVMInt8Type (), size);
}
} else {
printf ("%s\n", klass_name);
NOT_IMPLEMENTED;
return NULL;
}
}
Expand Down Expand Up @@ -3925,9 +3922,19 @@ emit_entry_bb (EmitContext *ctx, LLVMBuilderRef builder)
case LLVMArgVtypeAddr:
case LLVMArgVtypeByRef:
{
if (MONO_CLASS_IS_SIMD (ctx->cfg, mono_class_from_mono_type_internal (ainfo->type)))
MonoClass *klass = mono_class_from_mono_type_internal (ainfo->type);
if (MONO_CLASS_IS_SIMD (ctx->cfg, klass)) {
/* Treat these as normal values */
ctx->values [reg] = LLVMBuildLoad (builder, ctx->addresses [reg], "simd_vtype");
} else {
LLVMTypeRef simd_t = simd_class_to_llvm_type (ctx, klass);
if (simd_t) {
/* This is a SIMD type with an invalid non-primitive element type. Generate a
* fake value to allow the resulting LLVM IR to be well-formed.
*/
ctx->values [reg] = LLVMGetUndef (simd_t);
}
}
break;
}
default:
Expand Down Expand Up @@ -4482,8 +4489,10 @@ process_call (EmitContext *ctx, MonoBasicBlock *bb, LLVMBuilderRef *builder_ref,
#endif
}

gboolean is_simd = MONO_CLASS_IS_SIMD (ctx->cfg, mono_class_from_mono_type_internal (sig->ret));
MonoClass *klass = mono_class_from_mono_type_internal (sig->ret);
gboolean is_simd = MONO_CLASS_IS_SIMD (ctx->cfg, klass);
gboolean should_promote_to_value = FALSE;
LLVMTypeRef simd_t = simd_class_to_llvm_type (ctx, klass);
const char *load_name = NULL;
/*
* Convert the result. Non-SIMD value types are manipulated via an
Expand Down Expand Up @@ -4554,6 +4563,11 @@ process_call (EmitContext *ctx, MonoBasicBlock *bb, LLVMBuilderRef *builder_ref,
LLVMTypeRef addr_type = LLVMPointerType (type_to_llvm_type (ctx, sig->ret), 0);
LLVMValueRef addr = convert_full (ctx, addresses [call->inst.dreg], addr_type, FALSE);
values [ins->dreg] = LLVMBuildLoad (builder, addr, load_name);
} else if (simd_t) {
/* This is a SIMD type with an invalid non-primitive element type. Generate a
* fake value to allow the resulting LLVM IR to be well-formed.
*/
ctx->values [ins->dreg] = LLVMGetUndef (simd_t);
}

*builder_ref = ctx->builder;
Expand Down Expand Up @@ -5688,7 +5702,6 @@ process_bb (EmitContext *ctx, MonoBasicBlock *bb)
/* The return type is an LLVM aggregate type, so a bare bitcast cannot be used to do this conversion. */
int width = mono_type_size (sig->ret, NULL);
int elems = width / TARGET_SIZEOF_VOID_P;
/* The return value might not be set if there is a throw */
LLVMValueRef val = LLVMBuildBitCast (builder, lhs, LLVMVectorType (IntPtrType (), elems), "");
for (int i = 0; i < elems; ++i) {
LLVMValueRef element = LLVMBuildExtractElement (builder, val, const_int32 (i), "");
Expand All @@ -5713,7 +5726,7 @@ process_bb (EmitContext *ctx, MonoBasicBlock *bb)
break;
case LLVMArgVtypeAsScalar:
if (is_simd) {
retval = LLVMBuildBitCast (builder, values [ins->sreg1], ret_type, "setret_simd_vtype_as_scalar");
retval = LLVMBuildBitCast (builder, lhs, ret_type, "setret_simd_vtype_as_scalar");
} else {
g_assert (addresses [ins->sreg1]);
retval = LLVMBuildLoad (builder, LLVMBuildBitCast (builder, addresses [ins->sreg1], LLVMPointerType (ret_type, 0), ""), "");
Expand Down Expand Up @@ -6681,7 +6694,7 @@ process_bb (EmitContext *ctx, MonoBasicBlock *bb)
MonoInst *var = ins->inst_i0;
MonoClass *klass = var->klass;

if (var->opcode == OP_VTARG_ADDR && !MONO_CLASS_IS_SIMD(cfg, klass)) {
if (var->opcode == OP_VTARG_ADDR && !MONO_CLASS_IS_SIMD(cfg, klass) && !simd_class_to_llvm_type (ctx, klass)) {
/* The variable contains the vtype address */
values [ins->dreg] = values [var->dreg];
} else if (var->opcode == OP_GSHAREDVT_LOCAL) {
Expand Down Expand Up @@ -7296,12 +7309,14 @@ process_bb (EmitContext *ctx, MonoBasicBlock *bb)
dst = convert (ctx, LLVMBuildAdd (builder, convert (ctx, values [ins->inst_destbasereg], IntPtrType ()), LLVMConstInt (IntPtrType (), ins->inst_offset, FALSE), ""), LLVMPointerType (LLVMInt8Type (), 0));
}
break;
case OP_LOADV_MEMBASE:
case OP_LOADV_MEMBASE: {
if (!addresses [ins->dreg])
addresses [ins->dreg] = build_alloca (ctx, m_class_get_byval_arg (klass));
src = convert (ctx, LLVMBuildAdd (builder, convert (ctx, values [ins->inst_basereg], IntPtrType ()), LLVMConstInt (IntPtrType (), ins->inst_offset, FALSE), ""), LLVMPointerType (LLVMInt8Type (), 0));
LLVMValueRef base = convert (ctx, values [ins->inst_basereg], IntPtrType ());
src = convert (ctx, LLVMBuildAdd (builder, base, LLVMConstInt (IntPtrType (), ins->inst_offset, FALSE), ""), LLVMPointerType (LLVMInt8Type (), 0));
dst = LLVMBuildBitCast (builder, addresses [ins->dreg], LLVMPointerType (LLVMInt8Type (), 0), "");
break;
}
case OP_VMOVE:
if (!addresses [ins->sreg1])
addresses [ins->sreg1] = build_alloca (ctx, m_class_get_byval_arg (klass));
Expand Down