Avoid replacing realized service cache for singletons #52484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gltons - Scoped services resolved from the root container are singletons. This fixes a regression that caused the dynamically compiled callsite for scoped service to create new instances for scoped services resolved from root providers. - Added a test and added an optimized path that does not compile singletons and promoted singletons using the background thread.
ghost
added
the
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue Details
Fixes dotnet/efcore#24824
|
davidfowl
commented
May 8, 2021
| for (int i = 0; i < 10; i++) | ||
| { | ||
| Assert.Same(singleton, sp.GetRequiredService<A>()); | ||
| Thread.Sleep(10); // Give the background thread time to compile |
maryamariyan
reviewed
May 8, 2021
| } | ||
|
|
||
| [Fact] | ||
| public void ScopedServiceResolvedFromSingletonAfterCompilation() |
Contributor
There was a problem hiding this comment.
Do we also want to test a use case where a scoped service is registered in a scoped service provider and is depending on a singleton service?
Member
Author
There was a problem hiding this comment.
With the same loop? I want to say I'm sure we have that scenario covered, but never say never 😄
maryamariyan
approved these changes
May 8, 2021
Member
Author
|
Merging to unblock upstream |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/efcore#24824