-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[release/5.0] ignore empty domain for digest auth #50598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Tagging subscribers to this area: @dotnet/ncl |
|
@wfurt tactics asked to please ensure it's verified this fixes MongoDB (using 6.0 bits is OK). It says it was verified with 6.0 but not clear whether that's MongoDB. |
|
Yes, it was verified by the reporter to so I assume it was MongoDB. cc: @gao-artur to clarify. |
|
Yes, verified it with Atlas MongoDB and it worked. |
|
Ok great then @Anipik can merge when green. |
the leg timed out after passing all the tests., hence going forward and merging this one. |
Backport of #50348 to release/5.0
Fixes #50283
/cc @wfurt
Customer Impact
This breaks Atlas MongoDB. As popular framework it has impact on wider user group.
While technically this is not regression in SocketHttpHandler as it never work before, option to use legacy handler was removed in 5.0 so there is no good solution.
The fix is small as our validation was too strict as RFC allows empty token but we failed to parse and reported as invalid.
Testing
Reported verified fix with daily 6.0 build. New test case was also added.
Risk
Small