Big-endian test case fixes: System.Reflection #49693
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
stephentoub
reviewed
Mar 16, 2021
src/libraries/System.Reflection.Metadata/tests/Metadata/MetadataReaderTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Mar 16, 2021
* Fix endian assumptions in tests operating on PE headers / IL metadata (this is always encoded in little-endian byte order) * Fix expected result for BlobReader test (always little-endian) * Fix expected results for GUID tests
stephentoub
approved these changes
Mar 16, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix endian assumptions in tests operating on PE headers / IL metadata
(this is always encoded in little-endian byte order)
Fix expected result for BlobReader test (always little-endian)
Fix expected results for GUID tests