Faster EventSource attribute lookup #45621
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tarekgh, @tommcdon, @pjanotti Issue DetailsFrom #45121 (comment)
|
eerhardt
reviewed
Dec 5, 2020
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
Outdated
Show resolved
Hide resolved
benaadams
force-pushed
the
eventsource-attributes
branch
3 times, most recently
from
6216165 to
bdf3bf4
Compare
eerhardt
reviewed
Dec 8, 2020
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
Outdated
Show resolved
Hide resolved
eerhardt
reviewed
Dec 8, 2020
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
Outdated
Show resolved
Hide resolved
benaadams
force-pushed
the
eventsource-attributes
branch
from
63eadd1 to
641f0f5
Compare
stephentoub
reviewed
Jan 4, 2021
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2021
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 4, 2021
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
Outdated
Show resolved
Hide resolved
|
Do you have data on the impact of this? |
jnyrup
reviewed
Jan 9, 2021
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
Outdated
Show resolved
Hide resolved
Calling into the runtime's
Drops the allocations when the method is called From: To: As it no longer allocates since #44694 |
stephentoub
reviewed
Jan 15, 2021
There was a problem hiding this comment.
Then should it be ifdef'd out of corelib?
There was a problem hiding this comment.
I copied it from GetCustomAttributeHelper just below; not sure about what it means in practice?
stephentoub
reviewed
Jan 15, 2021
src/libraries/System.Private.CoreLib/src/System/Diagnostics/Tracing/EventSource.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Jan 15, 2021
benaadams
force-pushed
the
eventsource-attributes
branch
from
c9845e7 to
e6ed3f4
Compare
|
Rebased to restart CI |
benaadams
force-pushed
the
eventsource-attributes
branch
from
e6ed3f4 to
024ffa1
Compare
…acing/EventSource.cs Co-authored-by: Eric Erhardt <[email protected]>
Co-authored-by: Stephen Toub <[email protected]>
benaadams
force-pushed
the
eventsource-attributes
branch
from
024ffa1 to
c47a557
Compare
|
Aside: though this has 2 approvals and all tests passed, I can't merge as don't have commit rights |
stephentoub
approved these changes
Jan 22, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From #45121 (comment)
Contributes to #44598