Remove unnecessary IsStatic checks in ActivatorUtilities #45439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eerhardt
requested review from
BrennanConroy,
davidfowl,
halter73 and
maryamariyan
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsAs discussed in dotnet/aspnetcore#27974 (comment)
|
|
Tagging subscribers to this area: @eerhardt, @maryamariyan Issue DetailsAs discussed in dotnet/aspnetcore#27974 (comment)
|
stephentoub
approved these changes
Dec 2, 2020
eerhardt
force-pushed
the
UnnecessaryStaticChecks
branch
from
abd37a5 to
98b4671
Compare
Member
Author
|
mono Windows x64 failure is #45524 |
Member
Author
|
mono OSX x64 Debug failure is #24181 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in dotnet/aspnetcore#27974 (comment)