Address additional feedback from number-handling PRs #42505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layomia
changed the title
ahsonkhan
approved these changes
Sep 20, 2020
src/libraries/System.Text.Json/src/System/Text/Json/JsonHelpers.cs
Outdated
Show resolved
Hide resolved
....Json/src/System/Text/Json/Serialization/Converters/Collection/DictionaryDefaultConverter.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonNumberHandling.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonNumberHandling.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Text.Json/tests/Serialization/NumberHandlingTests.cs
Outdated
Show resolved
Hide resolved
ahsonkhan
approved these changes
Sep 22, 2020
steveharter
approved these changes
Sep 22, 2020
Contributor
|
@layomia note there was a STJ failure in |
layomia
force-pushed
the
number_handling_feedback
branch
from
37372ed to
82f1225
Compare
Contributor
Author
Thanks. It passed in a subsequent run. I don't think any issue there is due to this PR. I'll watch out for failures in other PRs. Test failures appear unrelated - 3 timeouts:
|
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #39363 & #39716.
FYI @ahsonkhan