[Mono] [GC] Fix TotalBytesAllocated and reenable test #42388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naricc
force-pushed
the
naricc/total-bytes-allocated-fix
branch
from
40363c0 to
c70305e
Compare
Member
|
The original failure wasn't deterministic. Utilizing CI to reproduce may not be best use of resources. Can we somehow run locally multiple times to catch any failures ? |
Contributor
Author
|
@SamMonoRT I have been running it locally, with no luck reproing it so far (I scripted it to run 5000 times on MacOS). I figured I should run it through CI a few times before re-enabling it, since it checks many more platforms than I can practically check. However, I am also working on iOS local runs. |
Contributor
Author
|
If we really want to save resources I could make a PR that runs only this test, on a bunch of platforms. |
This comment has been minimized.
This comment has been minimized.
naricc
force-pushed
the
naricc/total-bytes-allocated-fix
branch
from
5d44f94 to
1d5239f
Compare
naricc
force-pushed
the
naricc/total-bytes-allocated-fix
branch
from
290bed8 to
9d10a8e
Compare
naricc
changed the title
|
Tagging subscribers to this area: @BrzVlad |
BrzVlad
approved these changes
Sep 23, 2020
vargaz
approved these changes
Sep 23, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TotalBytesAllocated was sometimes not monotonically increasing on Mono. The reason was that when a thread was detached, we were not counting bytes allocated in its thread local allocation buffer. So, under the right circumstances the bytes would be counted while the thread is attached, but then get lost when the thread detached.
Fixes: #2280