Simplify JS interop for Blazor WebAssembly #40467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SteveSandersonMS
commented
Aug 6, 2020
| #endif | ||
|
|
||
| // Blazor specific custom routines - see dotnet_support.js for backing code | ||
| extern void* mono_wasm_invoke_js_blazor (MonoString **exceptionMessage, void *callInfo, void* arg0, void* arg1, void* arg2); |
Member
Author
There was a problem hiding this comment.
The reason for the arg0/arg1/arg2 params is so we can retain the earlier semantics about how reference and value types are represented in the unmarshalled interop cases.
Member
Author
|
@lewing I don't know what's going on with the build failures - they seem unrelated to this PR. |
lewing
approved these changes
Aug 6, 2020
Member
lewing
left a comment
lewing
left a comment
There was a problem hiding this comment.
Changes look fine. CI is having issues.
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we had two different JS interop primitives used by Blazor on WebAssembly:
mono_wasm_invoke_js_marshalledmono_wasm_invoke_js_unmarshalledThe exact set of params and semantics was embedded in the runtime and not updatable without runtime changes.
This PR proposes a single replacement for both the above -
mono_wasm_invoke_js_blazor- which:void*and passes it through. Blazor can therefore organize whatever set of parameters it wants on some struct and pass it through. As such it doesn't have to distinguish between sync and async calls, unlike the previous implementation.I'm suggesting we do this now so that we can implement some enhancements to JS interop on the Blazor side without needing further runtime changes.