Implement platform guards in OperatingSystem class #40457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
Collaborator
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jkotas
reviewed
Aug 6, 2020
src/libraries/System.Private.CoreLib/src/System/OperatingSystem.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 6, 2020
jkotas
reviewed
Aug 6, 2020
src/libraries/System.Private.CoreLib/src/System/OperatingSystem.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Aug 6, 2020
src/libraries/System.Private.CoreLib/src/System/OperatingSystem.cs
Outdated
Show resolved
Hide resolved
adamsitnik
commented
Aug 6, 2020
eerhardt
reviewed
Aug 6, 2020
adamsitnik
requested review from
EgorBo,
akoeplinger,
marek-safar and
steveisok
as code owners
adamsitnik
added a commit
to adamsitnik/runtime
that referenced
this pull request
Aug 6, 2020
…Platform. it won't compile now as the new guards have not been merged yet (dotnet#40457)
Member
|
/azp run runtime |
|
Azure Pipelines successfully started running 1 pipeline(s). |
danmoseley
reviewed
Aug 6, 2020
src/libraries/System.Runtime.Extensions/tests/System/OperatingSystemTests.cs
Outdated
Show resolved
Hide resolved
adamsitnik
added a commit
that referenced
this pull request
Aug 7, 2020
* Remove new platform members from OSPlatform * remove IsOSPlatformEarlierThan and IsOSPlatformOrLater methods * remove unused resource and dependency * delegate RuntimeInformation.IsOSPlatform to call OperatingSystem.IsOSPlatform. it won't compile now as the new guards have not been merged yet (#40457) * remove OSPlatform.Browser and it's usage
This was referenced Aug 7, 2020
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
* add Is$OsName methods to OperatingSystem class * add OperatingSystem.*VersionAtLeast methods * add IsOSPlatform and IsOSPlatformVersionAtLeast * add xml comments * address code review suggestions * move TARGET_* defines to a common file
Jacksondr5
pushed a commit
to Jacksondr5/runtime
that referenced
this pull request
Aug 10, 2020
* Remove new platform members from OSPlatform * remove IsOSPlatformEarlierThan and IsOSPlatformOrLater methods * remove unused resource and dependency * delegate RuntimeInformation.IsOSPlatform to call OperatingSystem.IsOSPlatform. it won't compile now as the new guards have not been merged yet (dotnet#40457) * remove OSPlatform.Browser and it's usage
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #40111
Fixes #40358