Skip to content

Fix Failing Casing Tests with Invariant Culture #39747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 22, 2020
Merged

Fix Failing Casing Tests with Invariant Culture #39747

merged 2 commits into from
Jul 22, 2020

Conversation

@tarekgh
Copy link
Member

@tarekgh tarekgh commented Jul 21, 2020

Fixes #39522
The test was failing because of a regression on Windows side.

@tarekgh
Fix Failing Casing Tests with Invariant Culture
0e06090 
The test was failing because of a regression on Windows side.
@ghost
Copy link

ghost commented Jul 21, 2020

Tagging subscribers to this area: @tarekgh, @safern, @krwq
Notify danmosemsft if you want to be subscribed.

safern
safern approved these changes Jul 21, 2020
View reviewed changes
Copy link
Member

@safern safern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because of a regression on Windows side.

Were you able to follow up with Windows?

@tarekgh
Copy link
Member Author

tarekgh commented Jul 22, 2020 •
edited
Loading

Were you able to follow up with Windows?

Yes. I even spent some time debugging it in Windows side as they somehow couldn't easily repro it. Possibly because of some more customization of the version they are using. Windows team still doing more investigation on that.

@GrabYourPitchforks
Copy link
Member

GrabYourPitchforks commented Jul 22, 2020

Reminder: we sometimes have ancient versions of ICU floating around, and it can cause unexpected test failures if we exercise scripts that were introduced within the past few years. See #1514 (comment) for some context.

This was referenced Jul 22, 2020
Closed
Closed
@tarekgh
Copy link
Member Author

tarekgh commented Jul 22, 2020

Reminder: we sometimes have ancient versions of ICU floating around, and it can cause unexpected test failures if we exercise scripts that were introduced within the past few years. See #1514 (comment) for some context.

Yes, we still support ICU version down to v50. but let's see if we run into such issue with this test and then we can fix it.

@tarekgh
Copy link
Member Author

tarekgh commented Jul 22, 2020

The CI finished successfully but for some reason showing one of the tasks still running.

@tarekgh tarekgh merged commit fc7381c into dotnet:master Jul 22, 2020
Jacksondr5 pushed a commit to Jacksondr5/runtime that referenced this pull request Aug 10, 2020
@tarekgh @Jacksondr5
Fix Failing Casing Tests with Invariant Culture (dotnet#39747)
63e2e16
@karelz karelz added this to the 5.0.0 milestone Aug 18, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 8, 2020
@tarekgh tarekgh deleted the FixCasingTestFaiingWithInvariant branch March 15, 2021 19:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@GrabYourPitchforks GrabYourPitchforks GrabYourPitchforks approved these changes

@safern safern safern approved these changes

Assignees

No one assigned

Labels

area-System.Globalization

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

System.Globalization.Nls.Tests.ToUpper/ToLower_netcore test failures in local environment

5 participants

@tarekgh @GrabYourPitchforks @safern @karelz @Dotnet-GitSync-Bot