Remove some = null!s from corelib
#36175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRobinsonMSFT
approved these changes
May 10, 2020
jkotas
reviewed
May 10, 2020
src/coreclr/src/System.Private.CoreLib/src/System/Reflection/RuntimeParameterInfo.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 10, 2020
src/coreclr/src/System.Private.CoreLib/src/System/Reflection/Emit/CustomAttributeBuilder.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 10, 2020
src/coreclr/src/System.Private.CoreLib/src/System/Reflection/Emit/CustomAttributeBuilder.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 10, 2020
src/coreclr/src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 10, 2020
src/coreclr/src/System.Private.CoreLib/src/System/Reflection/Emit/DynamicILGenerator.cs
Outdated
Show resolved
Hide resolved
jkotas
approved these changes
May 10, 2020
stephentoub
force-pushed
the
nullablecorelib
branch
from
007e1c3 to
9a00740
Compare
In some cases, this was achieved by: - Using [MemberNotNull] when it could be used to enable the compiler to appropriately follow the initialization - Making the field nullable and using `!`s at usage sites in cases where the `= null!` wasn't appropriate because the field could actually be null - Making the field nullable and adding null checks sparingly - Suppressing warnings in cases where fields weren't accessed in managed code - Removing stale cases where it wasn't necessary anymore anyway - Removing unnecessary empty internal/private ctors
stephentoub
force-pushed
the
nullablecorelib
branch
from
9a00740 to
9aff5b1
Compare
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases, this was achieved by:
!s at usage sites in cases where the= null!wasn't appropriate because the field could actually be null