Add POH size counter #36150
Merged
Add POH size counter #36150
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
May 8, 2020
| _gen1SizeCounter ??= new PollingCounter("gen-1-size", this, () => GC.GetGenerationSize(1)) { DisplayName = "Gen 1 Size", DisplayUnits = "B" }; | ||
| _gen2SizeCounter ??= new PollingCounter("gen-2-size", this, () => GC.GetGenerationSize(2)) { DisplayName = "Gen 2 Size", DisplayUnits = "B" }; | ||
| _lohSizeCounter ??= new PollingCounter("loh-size", this, () => GC.GetGenerationSize(3)) { DisplayName = "LOH Size", DisplayUnits = "B" }; | ||
| _pohSizeCounter ??= new PollingCounter("poh-size", this, () => GC.GetGenerationSize(4)) { DisplayName = "POH Size", DisplayUnits = "B" }; |
Member
There was a problem hiding this comment.
Is POH a well-enough understood acronym? Will we document that as pinned object heap anywhere?
Contributor
Author
There was a problem hiding this comment.
https://devblogs.microsoft.com/dotnet/announcing-net-5-0-preview-2/ announced it as POH (Pinned Object Heap). I could add the "(Pinned Object Heap)" part and keep it around until it is a more well-understood acronym by our customers. Do you have any thoughts here @noahfalk?
Member
There was a problem hiding this comment.
Note we are also using UOH in number of places that means LOH or POH.
I had a similar reaction to these TLAs. Some of the discussion is captured in #33445
stephentoub
approved these changes
May 8, 2020
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #35424.