Seal CompareInfo and TextInfo and remove virtual dispatch #31761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
SortKey as well? |
jkotas
approved these changes
Feb 4, 2020
Member
Author
Sorry, should've mentioned this earlier. There's a bug in |
tarekgh
approved these changes
Feb 5, 2020
ghost
added
the
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are no public or protected ctors for these types, so nobody is able to subclass them. There's no reason for them to be unsealed. Furthermore, once they're sealed, codegen won't need to emit a virtual dispatch pattern when calling the APIs.
/cc @terrajobst, when we had discussed this earlier we concluded that this wouldn't be a breaking change because no instance of a subclassed type could possibly exist. Is there any new thinking on this that I should be aware of?