Set installer.tasks.csproj to Platform AnyCPU for arch-agnostic output path #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
approved these changes
Nov 19, 2019
ViktorHofer
approved these changes
Nov 20, 2019
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies the workaround here, which is lost due to the installer project being shuffled outside
src/installer:runtime/src/installer/Directory.Build.props
Lines 24 to 26 in 3a2dc0f
I'm not sure if this helps with (or interferes with) #122... I hit some issues trying to run the installer build in #55 and this change seemed to help there. Haven't personally got a build through with this. Will need your help to tell if this change makes sense.