Skip to content

[release/8.0-staging] Add flags when the clang's major version is > 20.0 #121150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: release/8.0-staging
Choose a base branch
from
+19 −7
Open

[release/8.0-staging] Add flags when the clang's major version is > 20.0 #121150

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f35e269
Add flags when the clang's major version is > 20.0
AaronRobinsonMSFT Oct 28, 2025
27850df
Additional changes.
AaronRobinsonMSFT Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions eng/native/configurecompiler.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -500,9 +500,21 @@ if (CLR_CMAKE_HOST_UNIX)
#-fms-compatibility Enable full Microsoft Visual C++ compatibility
#-fms-extensions Accept some non-standard constructs supported by the Microsoft compiler

# Make signed arithmetic overflow of addition, subtraction, and multiplication wrap around
# using twos-complement representation (this is normally undefined according to the C++ spec).
add_compile_options(-fwrapv)
if((CMAKE_C_COMPILER_ID STREQUAL "Clang" AND CMAKE_C_COMPILER_VERSION VERSION_GREATER_EQUAL 20.0) OR
(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 20.0))
Comment on lines +503 to +504
Copy link
Member

@jkoritzinsky jkoritzinsky Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any concern here about Clang on macOS? If so, this should use MATCHES instead of STREQUAL.

Copy link
Member Author

@AaronRobinsonMSFT AaronRobinsonMSFT Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we care about macOS for these changes. Is there doc on why to use MATCHES vs STREQUAL in this case? Is it "clang" on macOS?

Copy link
Member

@jkoritzinsky jkoritzinsky Oct 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On macOS, it's AppleClang instead of Clang (as Apple has their forked build with slight differences).

# Make signed overflow well-defined. Implies the following flags in clang-20 and above.
# -fwrapv - Make signed arithmetic overflow of addition, subtraction, and multiplication wrap around
# using twos-complement representation (this is normally undefined according to the C++ spec).
# -fwrapv-pointer - The same as -fwrapv but for pointers.
add_compile_options(-fno-strict-overflow)

# Suppress C++ strict aliasing rules. This matches our use of MSVC.
add_compile_options(-fno-strict-aliasing)
else()
# Make signed arithmetic overflow of addition, subtraction, and multiplication wrap around
# using twos-complement representation (this is normally undefined according to the C++ spec).
add_compile_options(-fwrapv)
endif()

if(CLR_CMAKE_HOST_APPLE)
# Clang will by default emit objc_msgSend stubs in Xcode 14, which ld from earlier Xcodes doesn't understand.
Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/debug/di/rspriv.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6354,8 +6354,8 @@ class CordbThread : public CordbBase, public ICorDebugThread,
// Lazily initialized.
EXCEPTION_RECORD * m_pExceptionRecord;

static const CorDebugUserState kInvalidUserState = CorDebugUserState(-1);
CorDebugUserState m_userState; // This is the current state of the
static const int kInvalidUserState = -1;
int m_userState; // This is the current state of the
// thread, at the time that the
// left side synchronized

Expand Down
4 changes: 2 additions & 2 deletions src/coreclr/debug/di/rsthread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -783,7 +783,7 @@ CorDebugUserState CordbThread::GetUserState()
m_userState = pDAC->GetUserState(m_vmThreadToken);
}

return m_userState;
return (CorDebugUserState)m_userState;
}


Expand Down Expand Up @@ -887,7 +887,7 @@ HRESULT CordbThread::CreateStepper(ICorDebugStepper ** ppStepper)
//Returns true if current user state of a thread is USER_WAIT_SLEEP_JOIN
bool CordbThread::IsThreadWaitingOrSleeping()
{
CorDebugUserState userState = m_userState;
int userState = m_userState;
if (userState == kInvalidUserState)
{
//If m_userState is not ready, we'll read from DAC only part of it which
Expand Down
Loading