[wasm][coreclr] Allow memory growth for corerun #120844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also remove table growth option from browserhost, we don't need it as we don't have jiterpreter
There was a problem hiding this comment.
Pull Request Overview
This PR enables WebAssembly memory growth in the corerun host and removes table growth from the browserhost configuration as it is no longer needed without jiterpreter.
- Added -sALLOW_MEMORY_GROWTH=1 to corerun build.
- Removed -sALLOW_TABLE_GROWTH=1 from browserhost link options.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/native/corehost/browserhost/CMakeLists.txt | Removes table growth flag to simplify browserhost configuration. |
| src/coreclr/hosts/corerun/CMakeLists.txt | Adds memory growth flag to allow dynamic heap expansion for corerun. |
|
Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov |
pavelsavara
reviewed
Oct 17, 2025
pavelsavara
approved these changes
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove table growth option from browserhost, we don't need it as we don't have jiterpreter