Fix static virtual methods for delegate creation #118470
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Notably for creation of delegates to SVM methods which do not require generic dictionary lookups - Also a drive by fix of the vtable handling for NativeImageLayout which was causing crashes of the DAC when used in debug builds Fixes dotnet#109200
There was a problem hiding this comment.
Pull Request Overview
This PR fixes static virtual method (SVM) delegate creation that was causing crashes when creating delegates to SVM methods that don't require generic dictionary lookups. It also includes a drive-by fix for vtable handling in NativeImageLayout that was causing DAC crashes in debug builds.
Key changes:
- Adds type handle setting for static methods during method decoding
- Fixes vtable declaration for NativeImageLayout to work properly with DAC
- Removes test exclusions that were previously failing due to the fixed issue
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/tests/issues.targets | Removes exclusions for StaticVirtualMethods tests that are now fixed |
| src/coreclr/vm/zapsig.cpp | Adds type handle assignment for static methods in DecodeMethod |
| src/coreclr/vm/peimagelayout.h | Fixes DACCESS_COMPILE conditional placement for NativeImageLayout |
| src/coreclr/inc/vptr_list.h | Adds missing VPTR_CLASS entry for NativeImageLayout |
|
Tagging subscribers to this area: @mangod9 |
|
/azp run runtime-coreclr crossgen2-composite |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kg
approved these changes
Aug 6, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109200