Allow MethodDesc::GetILHeader to work correctly under rejit scenarios #118465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a BadFormatException that occurs when using ICorProfiler rejit to change the callset of a method in a different assembly. The issue was introduced by a previous change (#118318) and affects the MethodDesc::GetILHeader method in the CoreCLR runtime.
Key Changes:
- Reorders the RVA (Relative Virtual Address) validation check to occur after attempting to retrieve dynamic IL
- Ensures dynamic IL overrides are always checked before falling back to the original IL, even when RVA is 0
|
Tagging subscribers to this area: @steveisok, @dotnet/dotnet-diag |
jkotas
reviewed
Aug 6, 2025
hoyosjs
reviewed
Aug 6, 2025
What's a callset of a method? |
That's a typo - it should be callsite not callset. |
jkotas
reviewed
Aug 7, 2025
jkotas
reviewed
Aug 7, 2025
jkotas
approved these changes
Aug 7, 2025
jkotas
reviewed
Aug 7, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internal Visual Studio diagnostic testing caught an issue related to ICorProfiler rejit changing the callsite of a method in a different assembly can result in a BadFormatException. Regressed by #118318