SVE2 FP API's #118332
Merged
SVE2 FP API's #118332
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
3 tasks
amanasifkhalid
suggested changes
Aug 4, 2025
src/libraries/System.Private.CoreLib/src/System/Runtime/Intrinsics/Arm/Sve2.cs
Show resolved
Hide resolved
This was referenced Aug 6, 2025
jacob-crawley
force-pushed
the
sve2-fp-api
branch
from
75a72cb to
0e704e4
Compare
This was referenced Aug 13, 2025
jacob-crawley
force-pushed
the
sve2-fp-api
branch
from
0e704e4 to
1715a20
Compare
This was referenced Aug 14, 2025
jacob-crawley
force-pushed
the
sve2-fp-api
branch
from
1715a20 to
7707044
Compare
There was a problem hiding this comment.
Thanks for all the revisions on this! Looks like some of the conditional select scenarios for FloatingPointExponentialAccelerator failed (console log). Could you please take a look?
Contains implementations for: - AddRotateComplex - AddSaturateRotateComplex - ConvertToDoubleOdd - ConvertToSingleEvenRoundToOdd - Log2 - MultiplyAddRotateComplex - MultiplyAddRotateComplexBySelectedScalar - MultiplyAddRoundedDoublingSaturateHighRotateComplex* - ReciprocalEstimate - ReciprocalSqrtEstimate
Change-Id: I79efe0da0fd205b2856fa339f08daa3a5bacc200
jacob-crawley
force-pushed
the
sve2-fp-api
branch
from
7707044 to
2e68387
Compare
|
/ba-g mono test timed out |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@dotnet/arm64-contrib @amanasifkhalid @a74nh
Contributing towards #115479
Contains implementations for the set of SVE2 FP API's, aside from
ConvertToSingleOddandConvertToSingleOddRoundToOdd. This is due to concerns I have about the API proposal for these intrinsics being incorrect, when I have a resolution to my comments on this they will be implemented.