-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[clr-interp] Include clrinterpreter library in the iOS app bundle #117277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
kotlarmilos
merged 28 commits into
dotnet:main
from
kotlarmilos:feature/clr-interp-build-ios
Jul 25, 2025
Merged
[clr-interp] Include clrinterpreter library in the iOS app bundle #117277
kotlarmilos
merged 28 commits into
dotnet:main
from
kotlarmilos:feature/clr-interp-build-ios
Jul 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 3, 2025
Open
janvorli
reviewed
Jul 7, 2025
src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props
Outdated
Show resolved
Hide resolved
jkotas
reviewed
Jul 7, 2025
src/installer/pkg/sfx/Microsoft.NETCore.App/Directory.Build.props
Outdated
Show resolved
Hide resolved
This was referenced Jul 11, 2025
jkotas
reviewed
Jul 13, 2025
This was referenced Jul 15, 2025
/azp run runtime-ioslikesimulator |
Azure Pipelines successfully started running 1 pipeline(s). |
janvorli
reviewed
Jul 23, 2025
janvorli
approved these changes
Jul 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM modulo the comment, thank you!
/azp run runtime-ioslikesimulator |
Azure Pipelines successfully started running 1 pipeline(s). |
janvorli
approved these changes
Jul 23, 2025
akoeplinger
reviewed
Jul 23, 2025
This was referenced Jul 23, 2025
/azp run runtime-ioslikesimulator |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-ioslikesimulator |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run runtime-ioslikesimulator |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the installation target for clrinterpreter to include it in the sharedFramework, ensuring it is bundled in the iOS app.