Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text #117192
+32
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text. When the lengthOrIndicator is 0 the loop should be broken. This change fixes the issue dotnet#86490
dotnet-policy-service
bot
added
the
community-contribution
github-actions
bot
added
the
needs-area-label
stephentoub
reviewed
Jul 1, 2025
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcDataReader.cs
Outdated
Show resolved
Hide resolved
This was referenced Jul 1, 2025
stephentoub
reviewed
Jul 1, 2025
src/libraries/System.Data.Odbc/src/System/Data/Odbc/OdbcDataReader.cs
Outdated
Show resolved
Hide resolved
|
Is it possible to add a test for this? |
|
@dotnet-policy-service agree |
@stephentoub OdbcDataReaderTests is added. |
3 tasks
stephentoub
reviewed
Jul 11, 2025
Open
3 tasks
|
Thanks. I pulled down your change and tried running the test without the fix, and it still passes. Is this test validating what you expect it to validate? |
stephentoub
added
needs-author-action
|
Tagging subscribers to this area: @roji, @SamMonoRT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Infinite loop on OdbcDataReader.internalGetString with UTF-8 text.
When the lengthOrIndicator is 0 the loop should be broken.
This change fixes the issue #86490