Skip to content

Don't use property for msbuild versions in Versions.props #114298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 5, 2025
Merged

Don't use property for msbuild versions in Versions.props #114298

merged 1 commit into from
Apr 5, 2025

Conversation

@akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Apr 5, 2025

Avoids issues with source-build overwriting them.

@akoeplinger
Don't use property for msbuild versions in Versions.props
42e2db1 
Avoids issues with source-build overwriting them.
Copilot AI review requested due to automatic review settings April 5, 2025 08:43
Copilot AI reviewed Apr 5, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • eng/Versions.props: Language not supported

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Apr 5, 2025
This was referenced Apr 5, 2025
Open
Closed
Closed
@akoeplinger
Copy link
Member Author

akoeplinger commented Apr 5, 2025

/ba-g unrelated timeout

@akoeplinger akoeplinger merged commit 5188b3d into main Apr 5, 2025
155 of 160 checks passed
@akoeplinger akoeplinger deleted the akoeplinger-patch-2 branch April 5, 2025 12:51
@github-actions github-actions bot locked and limited conversation to collaborators May 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

Copilot code review Copilot Copilot left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees

@akoeplinger akoeplinger

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@akoeplinger @ViktorHofer