[release/9.0-staging] Fix VS div-by-0 in DacEnumerableHashTable code #113892
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
ghost
added
the
|
Tagging subscribers to this area: @mangod9 |
jeffschwMSFT
approved these changes
Mar 25, 2025
rbhanda
added
Servicing-approved
|
Friendly reminder that code complete is on April 14th for the May Release. If you'd like to get this change included in that release, please get a Tactics approval and merge this PR before that date. |
mikem8361
force-pushed
the
backport/pr-112542-to-release/9.0-staging
branch
from
60ed446 to
08daf0e
Compare
This was referenced Apr 3, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #112542 to release/9.0-staging
/cc @hoyosjs @mikem8361
Customer Impact
There have been some cases where public customer processes end up with a hashmap that has 0 buckets in it. In this state, we should bail early from lookups. In this case we failed to do so, and we end up performing a division by 0, affecting diagnostic scenarios and leading to crashes.
Regression
Testing
Manual testing. Visual Studio team ran validation on customer scenarios that confirmed this PR fixed cases seen in the wild.
Risk
Low. Affects only a DAC code path.