Skip to content

Conversation

@steveisok
Copy link
Member

Resolves CG alert

Copilot AI review requested due to automatic review settings March 11, 2025 17:03
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ghost ghost added the needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners label Mar 11, 2025
@steveisok steveisok requested a review from a team March 11, 2025 17:04
@steveisok
Copy link
Member Author

/backport to release/9.0-staging

@github-actions
Copy link
Contributor

Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/13794006273

@carlossanlop
Copy link
Contributor

I assume updating the toolset of S.T.J. does not have the same cascading effect on other repos as the regular S.T.J. package has, correct? cc @ericstj

@am11
Copy link
Member

am11 commented Mar 11, 2025

I assume updating the toolset of S.T.J. does not have the same cascading effect on other repos as the regular S.T.J. package has, correct? cc @ericstj

Isn't the opposite true based on the comment we added in 994e272 (i.e. this change needs to be coordinated with other repos + VS)?

@ViktorHofer
Copy link
Member

ViktorHofer commented Mar 11, 2025

No cascading effect as STJ with the toolset version doesn't get redistributed or promoted to a package dependency. It's a compile-only dependency. The only constraint is that the version used isn't newer than what ships inbox in VS (based on the VS images that we use in our CI).

@ericstj
Copy link
Member

ericstj commented Mar 11, 2025

Also if we happen to ship any of the tasks built here, that the minimum version of VS required by the SDK also has the update.

@steveisok steveisok merged commit 7efe7f7 into dotnet:main Mar 25, 2025
156 checks passed
@steveisok steveisok deleted the bump-stj-ver branch March 25, 2025 19:19
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants