- 
                Notifications
    
You must be signed in to change notification settings  - Fork 5.2k
 
More clean up to debugger attribute tests #112450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            sbomer
  merged 1 commit into
  dotnet:main
from
Unity-Technologies:remove-netfx-code-from-more-debugger-tests
  
      
      
   
  Feb 19, 2025 
      
    
                
     Merged
            
            More clean up to debugger attribute tests #112450
                    sbomer
  merged 1 commit into
  dotnet:main
from
Unity-Technologies:remove-netfx-code-from-more-debugger-tests
  
      
      
   
  Feb 19, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    | 
           @sbomer Please take a look  | 
    
  This was referenced Feb 12, 2025 
      
      
  
  Open
  
      
  
  Closed
  
      
  
  Closed
  
              
                    sbomer
  
              
              approved these changes
              
                  
                    Feb 13, 2025 
                  
              
              
            
            
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
| 
           /ba-g "Unrelated timeouts"  | 
    
I missed a few places with
```
	[SetupLinkerKeepDebugMembers ("true")]
```
back when I landed dotnet#89011
    d4b1cae    to
    6a6efbd      
    Compare
  
    | 
           @sbomer Can you merge the PR?  | 
    
    
  grendello 
      pushed a commit
        to grendello/runtime
      that referenced
      this pull request
    
      Feb 19, 2025 
    
    
      
  
    
      
    
  
I missed a few places with
```
	[SetupLinkerKeepDebugMembers ("true")]
```
back when I landed dotnet#89011
    
  
      Sign up for free
      to subscribe to this conversation on GitHub.
      Already have an account?
      Sign in.
  
      Labels
      
    community-contribution
  Indicates that the PR has been added by a community member 
  
    linkable-framework
  Issues associated with delivering a linker friendly framework 
  
    needs-area-label
  An area label is needed to ensure this gets routed to the appropriate area owners 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
I missed a few places with
back when I landed #89011